Server version of Hercules #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split hercules into a server (C) and monitor (go) process
checked common section checked receiver section checked sender section
…pini/hercules-server into server
This reverts commit 5b50898.
For large files and with many lost packets, the number of ACK packets reuquired to convey all ACK ranges can grow too large, leading to the sender receiving more ACKs than it can process. Change ACK sending as follows: Acks are still sent at a regular interval, but only up to 5 packets at once. Acks sent in the next interval pick up where the previous one left off, so acks now "loop" over multiple intervals.
There was a problem hiding this comment.
Thanks Marco for opening this PR!
I looked through the documentation (and only the documentation) and found a few typos.
Note that I commented on the Markdown files instead of the manual files as they were easier to read. So probably you will update the manual files and then just rebuild the Markdown files.
Hope this helps.
|
|
||
| **DefaultNumPaths**=*int* | ||
|
|
||
| > Specify how many SCION path to use for data transfers. |
| > When setting this option, note that the file paths supplied by users will be | ||
| > interpreted relative to this new directory. | ||
|
|
||
| > Example: DropUser = "/mnt/data/" |
There was a problem hiding this comment.
Shouldn't this be ChrootDir = "/mnt/data/"?
| * For transfers to any other host in AS | ||
| *18-a:b:c*: | ||
|
|
||
| * A payload length of 1400 should be used. |
There was a problem hiding this comment.
1400B to be consistent with previous payload length definition.
| # DESCRIPTION | ||
|
|
||
| **hercules-server** | ||
| is the server component of the Hercules file transfer sytem. |
| # DESCRIPTION | ||
|
|
||
| **hercules-monitor** | ||
| is the monitor component of the Hercules file transfer sytem. |
|
|
||
| #### Termination | ||
| - Using larger packets (jumbo frames) can also improve performance. Hercules supports jumbo frames up to a MTU of 9000 bytes. Note, however, that support for jumbo frames (via XDP multibuffer/fragments) requires at least kernel 6.6. On older versions the packet size is limited to 3000 bytes. | ||
| Further, support for jumbo frames in combination with zero-copy mode is device-dependent. To use jumbo frames on such a device, disable zero-copy in Hercules' file. |
There was a problem hiding this comment.
"Hercules' config file" instead of "Hercules' file". Or what did you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Hercules from a 1 transfer at-a-time tool to a long-running server.